Bug 115103

Summary: ElementData should use 'unsigned' attribute indices.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, esprehn+autocc, kling, koivisto, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch koivisto: review+

Andreas Kling
Reported 2013-04-24 05:25:58 PDT
We should use 32-bit indices for element attributes, especially now that Vector is already limited to 32-bit capacity.
Attachments
Proposed patch (17.38 KB, patch)
2013-04-24 05:28 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-04-24 05:28:20 PDT
Created attachment 199417 [details] Proposed patch
Andreas Kling
Comment 2 2013-04-24 05:29:23 PDT
Oliver/Antti, what do you think about this? It seems to me like we want to minimize the amount of code that deals in size_t indices into arrays/vectors whose capacity is limited to 32 bits.
Antti Koivisto
Comment 3 2013-04-24 12:14:34 PDT
Comment on attachment 199417 [details] Proposed patch Sounds great to me.
Andreas Kling
Comment 4 2013-04-24 13:02:14 PDT
Committed r149061: <http://trac.webkit.org/changeset/149061>
Note You need to log in before you can comment on or make changes to this bug.