Bug 115092

Summary: [BlackBerry] Remove the setContentsToColor flavor of LayerTiler::TextureJob
Product: WebKit Reporter: Arvid Nilsson <anilsson>
Component: WebKit BlackBerryAssignee: Arvid Nilsson <anilsson>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, anlo, cgarcia, commit-queue, jpetsovits, rwlbuis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Arvid Nilsson
Reported 2013-04-24 00:25:36 PDT
This is dead code that was used with the Skia backend, but no longer useful. With Skia, when we detected that a layer contained only solid color, we'd draw a 1x1 texture containing that color across the layer bounds. With the GL renderer, for solid color layers the display list will only contain commands to draw the solid color, so the optimization is "built in". This cleanup is done as part of PR 273550. The WebOverlay still uses the TextureCacheCompositingThread::textureForColor() so that one can stay for now.
Attachments
Patch (6.38 KB, patch)
2013-04-24 00:33 PDT, Arvid Nilsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Arvid Nilsson
Comment 1 2013-04-24 00:33:44 PDT
Created attachment 199399 [details] Patch
Arvid Nilsson
Comment 2 2013-04-24 00:41:51 PDT
Comment on attachment 199399 [details] Patch Thanks cgarcia =)
WebKit Commit Bot
Comment 3 2013-04-24 01:08:50 PDT
Comment on attachment 199399 [details] Patch Clearing flags on attachment: 199399 Committed r149019: <http://trac.webkit.org/changeset/149019>
WebKit Commit Bot
Comment 4 2013-04-24 01:08:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.