Bug 115089

Summary: Function parameter quotePair can be passed by reference
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebCore Misc.Assignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kangil Han
Reported 2013-04-23 22:57:08 PDT
Function parameter quotePair can be passed by reference
Attachments
Patch (2.01 KB, patch)
2013-04-23 22:59 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Patch (2.04 KB, patch)
2013-04-24 17:15 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2013-04-23 22:59:53 PDT
Created attachment 199388 [details] Patch
Alexey Proskuryakov
Comment 2 2013-04-24 09:02:55 PDT
Comment on attachment 199388 [details] Patch r=me I don't think that "[Minor code refactoring]" is a useful prefix. We use bracketed prefixes for platform specific bugs/patches as a signal that most people can skip those.
Kangil Han
Comment 3 2013-04-24 17:15:39 PDT
Created attachment 199538 [details] Patch
Kangil Han
Comment 4 2013-04-24 17:16:21 PDT
(In reply to comment #2) > I don't think that "[Minor code refactoring]" is a useful prefix. We use bracketed prefixes for platform specific bugs/patches as a signal that most people can skip those. Done. :)
WebKit Commit Bot
Comment 5 2013-04-24 17:43:09 PDT
Comment on attachment 199538 [details] Patch Clearing flags on attachment: 199538 Committed r149080: <http://trac.webkit.org/changeset/149080>
WebKit Commit Bot
Comment 6 2013-04-24 17:43:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.