Bug 115060

Summary: Don't create compositing layers for sticky position unless using the ScrollingCoordinator
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Simon Fraser (smfr) 2013-04-23 14:23:06 PDT
Don't create compositing layers for sticky position unless using the ScrollingCoordinator
Comment 1 Simon Fraser (smfr) 2013-04-23 14:25:44 PDT
Created attachment 199325 [details]
Patch
Comment 2 Tim Horton 2013-04-23 14:28:57 PDT
Comment on attachment 199325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199325&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:2193
> +        if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())
> +            compositeSticky = scrollingCoordinator->coordinatesScrollingForFrameView(m_renderView->frameView());
> +        return compositeSticky;

The same logic exists in other places (shouldCompositeOverflowControls, for one). Should we maybe factor it out?
Comment 3 Simon Fraser (smfr) 2013-04-23 15:00:39 PDT
http://trac.webkit.org/changeset/148998