Bug 115057 – Filled out more cases of branch folding in bytecode when emitting expressions into a branching context

• Component: New Bugs
• Status: RESOLVED FIXED

[Geoffrey Garen]

Filled out more cases of branch folding in bytecode when emitting expressions into a branching context

[Geoffrey Garen]

Created attachment 199328 [details]
Patch

[Filip Pizlo]

Comment on attachment 199328 [details]
Patch

Cool!

[WebKit Commit Bot]

Attachment 199328 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/regress/branch-fold-expected.txt', u'LayoutTests/fast/js/regress/branch-fold.html', u'LayoutTests/fast/js/regress/script-tests/branch-fold.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.order', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h', u'Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp', u'Source/JavaScriptCore/parser/ASTBuilder.h', u'Source/JavaScriptCore/parser/NodeConstructors.h', u'Source/JavaScriptCore/parser/Nodes.h', u'Source/JavaScriptCore/parser/Parser.cpp', u'Source/JavaScriptCore/parser/ResultType.h', u'Source/JavaScriptCore/runtime/JSCJSValueInlines.h', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/JSCellInlines.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/TriState.h']" exit_code: 1
Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1054:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1056:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1058:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 3 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Committed r148999: <http://trac.webkit.org/changeset/148999>

[Filip Pizlo]

This broke http://kripken.github.io/ammo.js/examples/new/ammo.html

[Filip Pizlo]

Reopening because it broke things.

[Filip Pizlo]

Rolled out in http://trac.webkit.org/changeset/149158

[Geoffrey Garen]

Committed r149236: <http://trac.webkit.org/changeset/149236>