Bug 115018

Summary: PDFPlugin: Cursor should become an i-beam when over selectable text
Product: WebKit Reporter: Tim Horton <thorton>
Component: PDFAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
better patch ap: review+

Tim Horton
Reported 2013-04-23 00:25:10 PDT
<rdar://problem/12645012> I'd love a way to do this without IPC every mouse-move, but that would require getting reliable mouse-enter events (so that I could cache the last cursor and bail if it hasn't changed, unless this is the first mouse-move since the plugin has been entered), which I'm not yet sure how to do.
Attachments
patch (4.93 KB, patch)
2013-04-23 00:25 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
better patch (7.58 KB, patch)
2013-04-23 13:26 PDT, Tim Horton 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-04-23 00:25:58 PDT
Created attachment 199163 [details] patch
Alexey Proskuryakov
Comment 2 2013-04-23 09:34:48 PDT
Comment on attachment 199163 [details] patch It feels wrong to send a message on every MouseMove event. Unsure what to suggest though.
Tim Horton
Comment 3 2013-04-23 13:26:37 PDT
Created attachment 199321 [details] better patch
Tim Horton
Comment 4 2013-04-23 13:27:00 PDT
Comment on attachment 199321 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=199321&action=review > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.h:35 > +#include <WebCore/Cursor.h> Don't need this anymore.
Tim Horton
Comment 5 2013-04-24 22:30:00 PDT
http://trac.webkit.org/changeset/149091
Note You need to log in before you can comment on or make changes to this bug.