Bug 115009

Summary: Remove unused code of RefCounted after chromium removal
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarcelo, commit-queue, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
rniwa: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 none

Benjamin Poulain
Reported 2013-04-22 20:26:12 PDT
Remove unused code of RefCounted after chromium removal
Attachments
Patch (1.70 KB, patch)
2013-04-22 20:29 PDT, Benjamin Poulain 		rniwa: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (600.67 KB, application/zip)
2013-04-22 23:45 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-04-22 20:29:35 PDT
Created attachment 199140 [details] Patch
Build Bot
Comment 2 2013-04-22 23:44:58 PDT
Comment on attachment 199140 [details] Patch Attachment 199140 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/141661 New failing tests: svg/custom/getscreenctm-in-scrollable-svg-area.xhtml svg/custom/getscreenctm-in-scrollable-div-area.xhtml svg/custom/getscreenctm-in-scrollable-div-area-nested.xhtml
Build Bot
Comment 3 2013-04-22 23:45:00 PDT
Created attachment 199157 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Alexey Proskuryakov
Comment 4 2013-04-22 23:47:15 PDT
There is an ASSERT(m_refCount > 0) in this file, please update it accordingly.
Ryosuke Niwa
Comment 5 2013-04-22 23:49:09 PDT
(In reply to comment #4) > There is an ASSERT(m_refCount > 0) in this file, please update it accordingly. Oh, you mean to ASSERT(m_refCount)?
Benjamin Poulain
Comment 6 2013-04-23 12:24:31 PDT
(In reply to comment #4) > There is an ASSERT(m_refCount > 0) in this file, please update it accordingly. That was intentional, in my opinion ASSERT(m_refCount > 0) makes more sense. But I don't mind changing it.
Benjamin Poulain
Comment 7 2013-04-23 12:27:45 PDT
Committed r148981: <http://trac.webkit.org/changeset/148981>
Note You need to log in before you can comment on or make changes to this bug.