|Summary:||Change approach to third-party blocking for LocalStorage|
|Product:||WebKit||Reporter:||Vicki Pfau <jeffrey+webkit>|
|Component:||WebCore Misc.||Assignee:||Vicki Pfau <jeffrey+webkit>|
|Severity:||Normal||CC:||buildbot, ddkilzer, mjs, rniwa, sam, wilander|
|Version:||528+ (Nightly build)|
Description Vicki Pfau 2013-04-22 18:00:01 PDT
The approach to blocking LocalStorage introduce in r125335 has broken many sites that either depend on LocalStorage sufficiently that disabling it has broken functionality, or sites that blindly try to access it without attempting to catch an exception. We need an approach that won't break sites like these. <rdar://problem/13650298>
Comment 2 Build Bot 2013-04-22 20:47:48 PDT
Comment on attachment 199134 [details] Patch Attachment 199134 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/199351 New failing tests: http/tests/security/cross-origin-local-storage-wk1.html
Comment 3 Build Bot 2013-04-22 20:47:49 PDT
Created attachment 199142 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Comment 4 Vicki Pfau 2013-04-23 11:24:17 PDT
Looks like I neglected to rebaseline a test on platforms other that mac (including mac-wk2). It looks like it's producing the right result, though, so I'd just need to land a patch with the rebaselined results--there's no code change from the patch I previously uploaded.
Comment 5 Maciej Stachowiak 2013-04-29 14:30:25 PDT
Comment on attachment 199134 [details] Patch r=me but don't forget to fix the wk2 results.