Summary: | [Mac] HEAD requests changed to GET after 301, 302, and 303 redirections (http/tests/xmlhttprequest/head-redirection.html) | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||||||||||||||||
Component: | Page Loading | Assignee: | Rob Buis <rbuis> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | achristensen, ap, beidson, cdumez, commit-queue, ews-watchlist, fred.wang, mnot, rbuis, rniwa, webkit-bug-importer, youennf | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Attachments: |
|
Description
Jessie Berlin
2013-04-22 10:12:20 PDT
Created attachment 356168 [details]
Patch
Comment on attachment 356168 [details] Patch Attachment 356168 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10213178 New failing tests: imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker.html imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.html http/tests/xmlhttprequest/head-redirection.html Created attachment 356169 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 356175 [details]
Patch
Comment on attachment 356175 [details] Patch Attachment 356175 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10214966 New failing tests: http/tests/xmlhttprequest/head-redirection.html imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.html imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker.html Created attachment 356181 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 356175 [details] Patch Attachment 356175 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10215039 New failing tests: http/tests/xmlhttprequest/head-redirection.html Created attachment 356186 [details]
Archive of layout-test-results from ews115 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 356199 [details]
Patch
Created attachment 356233 [details]
Patch
Comment on attachment 356233 [details] Patch This LGTM but maybe people who were involved in bug 110127 should take a look ;-) This behavior is HTTP generic and not browser specific. I would believe CFNetwork should do the right thing for us. If they cannot, then we can go on with this patch. > I would believe CFNetwork should do the right thing for us.
Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET?
>> I would believe CFNetwork should do the right thing for us. >Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET? I realize you probably can't comment. An alternative could be to go with the patch but add a "FIXME: remove when CFNetwork changes/fixes behavior". WDYT? (In reply to Rob Buis from comment #16) > >> I would believe CFNetwork should do the right thing for us. > > >Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET? > > I realize you probably can't comment. An alternative could be to go with the > patch but add a "FIXME: remove when CFNetwork changes/fixes behavior". WDYT? I guess even FIXME(rdar://problem/13706454) (In reply to Frédéric Wang (:fredw) from comment #17) > (In reply to Rob Buis from comment #16) > > >> I would believe CFNetwork should do the right thing for us. > > > > >Do you know if there is an existing bug filed against CFNetwork to not change the HEAD requests into GET? > > > > I realize you probably can't comment. An alternative could be to go with the > > patch but add a "FIXME: remove when CFNetwork changes/fixes behavior". WDYT? > > I guess even FIXME(rdar://problem/13706454) Let's do that for now. Created attachment 356593 [details]
Patch
Comment on attachment 356593 [details]
Patch
I added the FIXME.
Comment on attachment 356593 [details] Patch Clearing flags on attachment: 356593 Committed r238891: <https://trac.webkit.org/changeset/238891> All reviewed patches have been landed. Closing bug. |