Bug 114953

Summary:

BlackBerry: fix call to PluginLayerWebKitThread::setHolePunchRect()

Product:

WebKit

Reporter:

Alberto Garcia <berto>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

111729

Attachments:

Description	Flags
Patch	none

Description Alberto Garcia 2013-04-22 06:36:08 PDT

We have this error:

Source/WebCore/plugins/blackberry/NPCallbacksBlackBerry.cpp:68:28: error: 'class WebCore::LayerWebKitThread' has no member named 'setHolePunchRect'

The problem is that HolePunchData holds a pointer to LayerWebKitThread (PlatformLayer).

Comment 1 Alberto Garcia 2013-04-22 06:44:17 PDT

Created attachment 199023 [details]
Patch

This would be the simplest patch, and is consistent with what it's
already being done in other parts of the same code.

However I wonder if it wouldn't be better to change the pointer in
HolePunchData directly.

Comment 2 Rob Buis 2013-05-09 11:07:58 PDT

Comment on attachment 199023 [details]
Patch

LGTM.

Comment 3 WebKit Commit Bot 2013-05-09 11:37:53 PDT

Comment on attachment 199023 [details]
Patch

Clearing flags on attachment: 199023

Committed r149827: <http://trac.webkit.org/changeset/149827>

Comment 4 WebKit Commit Bot 2013-05-09 11:37:55 PDT

All reviewed patches have been landed.  Closing bug.