Bug 114942 – [BlackBerry] Need to send out change event for date/color picker

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Charles Wei]

For now the date/time/color are implemented with PagePopups, when the user finishes selection and closes the popup, we set the value to the element but there's no change event sent out. so the javascript can't get the change event to perform its work if the application registers change handler. 

We need to instruct the webkit to send out 'change' event when the user selection changes.

Internal tracking No. : 326167

[Charles Wei]

Created attachment 199011 [details]
Patch

[Mike Fenton]

Looks good, but do we need it for select as well? 

void InputHandler::setInputValue(const WTF::String& value) would be the place if it's required.

[Charles Wei]

(In reply to comment #2)
> Looks good, but do we need it for select as well? 
> 
> void InputHandler::setInputValue(const WTF::String& value) would be the place if it's required.

No, we don't . Selection change is already taken care of in SelectPopupClient::notifySelectionChange() which in turn calls :

m_element->dispatchFormControlChangeEvent(); 

to send out the change event.

[Carlos Garcia Campos]

Comment on attachment 199011 [details]
Patch

It makes sense.

[WebKit Commit Bot]

Comment on attachment 199011 [details]
Patch

Clearing flags on attachment: 199011

Committed r148959: <http://trac.webkit.org/changeset/148959>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.