Bug 114898

Summary: Improve StringImpl code density for older ARM hardware
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, ggaren
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Benjamin Poulain
Reported 2013-04-19 23:25:28 PDT
Improve StringImpl code density for older ARM hardware
Attachments
Patch (2.71 KB, patch)
2013-04-19 23:30 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (4.16 KB, patch)
2013-04-20 00:47 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (4.82 KB, patch)
2013-04-20 01:16 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (8.12 KB, patch)
2013-04-20 19:37 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-04-19 23:30:07 PDT
Created attachment 198929 [details] Patch
Benjamin Poulain
Comment 2 2013-04-19 23:30:49 PDT
Bug <rdar://problem/13700356>
Build Bot
Comment 3 2013-04-20 00:04:04 PDT
Comment on attachment 198929 [details] Patch Attachment 198929 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/15455
Benjamin Poulain
Comment 4 2013-04-20 00:47:55 PDT
Created attachment 198932 [details] Patch
Benjamin Poulain
Comment 5 2013-04-20 01:16:37 PDT
Created attachment 198935 [details] Patch
Build Bot
Comment 6 2013-04-20 02:01:21 PDT
Comment on attachment 198935 [details] Patch Attachment 198935 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/186328
Geoffrey Garen
Comment 7 2013-04-20 16:25:55 PDT
Comment on attachment 198935 [details] Patch r=me You'll need to update the Windows export symbol before landing.
Geoffrey Garen
Comment 8 2013-04-20 16:26:35 PDT
The required symbol name is: ??1StringImpl@WTF@@QAE@XZ.
Benjamin Poulain
Comment 9 2013-04-20 19:37:04 PDT
Created attachment 198951 [details] Patch
Benjamin Poulain
Comment 10 2013-04-21 23:20:06 PDT
Comment on attachment 198951 [details] Patch Clearing flags on attachment: 198951 Committed r148857: <http://trac.webkit.org/changeset/148857>
Benjamin Poulain
Comment 11 2013-04-21 23:20:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.