Bug 114898

Summary: Improve StringImpl code density for older ARM hardware
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, ggaren
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Benjamin Poulain 2013-04-19 23:25:28 PDT 
Improve StringImpl code density for older ARM hardware
Comment 1 Benjamin Poulain 2013-04-19 23:30:07 PDT 
Created attachment 198929 [details]
Patch
Comment 2 Benjamin Poulain 2013-04-19 23:30:49 PDT 
Bug <rdar://problem/13700356>
Comment 3 Build Bot 2013-04-20 00:04:04 PDT 
Comment on attachment 198929 [details]
Patch

Attachment 198929 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/15455
Comment 4 Benjamin Poulain 2013-04-20 00:47:55 PDT 
Created attachment 198932 [details]
Patch
Comment 5 Benjamin Poulain 2013-04-20 01:16:37 PDT 
Created attachment 198935 [details]
Patch
Comment 6 Build Bot 2013-04-20 02:01:21 PDT 
Comment on attachment 198935 [details]
Patch

Attachment 198935 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/186328
Comment 7 Geoffrey Garen 2013-04-20 16:25:55 PDT 
Comment on attachment 198935 [details]
Patch

r=me

You'll need to update the Windows export symbol before landing.
Comment 8 Geoffrey Garen 2013-04-20 16:26:35 PDT 
The required symbol name is: ??1StringImpl@WTF@@QAE@XZ.
Comment 9 Benjamin Poulain 2013-04-20 19:37:04 PDT 
Created attachment 198951 [details]
Patch
Comment 10 Benjamin Poulain 2013-04-21 23:20:06 PDT 
Comment on attachment 198951 [details]
Patch

Clearing flags on attachment: 198951

Committed r148857: <http://trac.webkit.org/changeset/148857>
Comment 11 Benjamin Poulain 2013-04-21 23:20:11 PDT 
All reviewed patches have been landed.  Closing bug.