Bug 114892

Summary: [BlackBerry] Update BatteryClientBlackBerry to use our port's new listener interface
Product: WebKit Reporter: otcheung
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

otcheung
Reported 2013-04-19 15:43:49 PDT
^
Attachments
Patch (5.79 KB, patch)
2013-04-19 15:49 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (5.81 KB, patch)
2013-04-19 16:00 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (5.84 KB, patch)
2013-04-22 08:07 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
otcheung
Comment 1 2013-04-19 15:49:35 PDT
Created attachment 198917 [details] Patch
otcheung
Comment 2 2013-04-19 16:00:05 PDT
Created attachment 198919 [details] Patch
Rob Buis
Comment 3 2013-04-22 08:05:51 PDT
Comment on attachment 198919 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198919&action=review LGTM. > Source/WebKit/blackberry/WebCoreSupport/BatteryClientBlackBerry.cpp:40 > + m_isActive = true; You can group these, no need to set m_isActive to true if you already know it is true. > Source/WebKit/blackberry/WebCoreSupport/BatteryClientBlackBerry.cpp:47 > + m_isActive = false; Ditto.
otcheung
Comment 4 2013-04-22 08:07:15 PDT
Created attachment 199030 [details] Patch
Rob Buis
Comment 5 2013-04-22 08:14:50 PDT
Comment on attachment 199030 [details] Patch Looks good.
WebKit Commit Bot
Comment 6 2013-04-22 08:42:48 PDT
Comment on attachment 199030 [details] Patch Clearing flags on attachment: 199030 Committed r148885: <http://trac.webkit.org/changeset/148885>
WebKit Commit Bot
Comment 7 2013-04-22 08:42:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.