Bug 114887

Summary: [BlackBerry] URL decode data: URLs before passing them to the platform media player
Product: WebKit Reporter: John Griggs <jgriggs>
Component: MediaAssignee: John Griggs <jgriggs>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch - Fixed ChangeLog issues in previous patch
none
Patch - More ChangeLog fixes. none

John Griggs
Reported 2013-04-19 13:20:30 PDT
decode URL escape sequences in data: URLs before passing them to the BlackBerry platform media player
Attachments
Patch (2.02 KB, patch)
2013-04-22 07:11 PDT, John Griggs 		no flags
DetailsFormatted DiffDiff
Patch - Fixed ChangeLog issues in previous patch (1.99 KB, patch)
2013-04-22 09:02 PDT, John Griggs 		no flags
DetailsFormatted DiffDiff
Patch - More ChangeLog fixes. (1.93 KB, patch)
2013-04-22 09:12 PDT, John Griggs 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
John Griggs
Comment 1 2013-04-22 07:11:41 PDT
Created attachment 199025 [details] Patch
Rob Buis
Comment 2 2013-04-22 08:51:48 PDT
Comment on attachment 199025 [details] Patch Ok.
WebKit Commit Bot
Comment 3 2013-04-22 08:52:43 PDT
Comment on attachment 199025 [details] Patch Rejecting attachment 199025 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--non-interactive', 199025, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Liam Quinn found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/141468
John Griggs
Comment 4 2013-04-22 09:02:26 PDT
Created attachment 199037 [details] Patch - Fixed ChangeLog issues in previous patch
John Griggs
Comment 5 2013-04-22 09:12:08 PDT
Created attachment 199038 [details] Patch - More ChangeLog fixes.
Rob Buis
Comment 6 2013-04-22 09:14:01 PDT
Comment on attachment 199038 [details] Patch - More ChangeLog fixes. Ok.
WebKit Commit Bot
Comment 7 2013-04-22 09:42:49 PDT
Comment on attachment 199038 [details] Patch - More ChangeLog fixes. Clearing flags on attachment: 199038 Committed r148890: <http://trac.webkit.org/changeset/148890>
WebKit Commit Bot
Comment 8 2013-04-22 09:42:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.