Bug 114886

Summary: Remove the remaining Skia #ifdefs
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: PlatformAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, berto, rwlbuis
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115232    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Martin Robinson
Reported 2013-04-19 11:37:28 PDT
The Skia code is gone now, so the #ifdefs don't make much sense any longer.
Attachments
Patch (45.71 KB, patch)
2013-04-19 11:56 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch for landing (45.66 KB, patch)
2013-04-22 15:06 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (46.47 KB, patch)
2013-04-25 09:56 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-04-19 11:43:17 PDT
Yes, I think we can remove them all. Adding Rob to Cc.
Martin Robinson
Comment 2 2013-04-19 11:56:45 PDT
Created attachment 198906 [details] Patch
Build Bot
Comment 3 2013-04-19 12:25:52 PDT
Comment on attachment 198906 [details] Patch Attachment 198906 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/159183
Benjamin Poulain
Comment 4 2013-04-20 01:29:19 PDT
Comment on attachment 198906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198906&action=review Awesome! > Source/WebCore/platform/graphics/GraphicsContext.cpp:861 > +#if !USE(CG) // append && !USE(MYPLATFORM) here to optimize ellipses on your platform. That comment is pretty dumb. You can remove it.
Martin Robinson
Comment 5 2013-04-22 15:06:12 PDT
Created attachment 199115 [details] Patch for landing
Alberto Garcia
Comment 6 2013-04-23 23:41:03 PDT
I guess you can also remove the SKIA defs in Source/WTF/wtf/Platform.h and Source/WebKit/blackberry/WebCoreSupport/AboutDataUseFeatures.in
Martin Robinson
Comment 7 2013-04-24 07:29:22 PDT
Hrm. EWS seems to be MIA.
Martin Robinson
Comment 8 2013-04-25 09:56:00 PDT
Created attachment 199677 [details] Patch
Alberto Garcia
Comment 9 2013-04-26 00:26:07 PDT
(In reply to comment #8) > Created an attachment (id=199677) [details] > Patch Looks good to me.
Alberto Garcia
Comment 10 2013-04-26 00:34:33 PDT
I just saw that there's also Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceSkia.cpp, which I guess should be removed as well.
Martin Robinson
Comment 11 2013-04-26 09:23:33 PDT
Committed r149193: <http://trac.webkit.org/changeset/149193>
Note You need to log in before you can comment on or make changes to this bug.