Bug 114861

Summary: [BlackBerry] Add dummy implementations of DragData::droppedFileSystemId()
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, mifenton, rwlbuis, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch
cgarcia: review-, cgarcia: commit-queue-
Patch none

Alberto Garcia
Reported 2013-04-19 02:24:30 PDT
AccessibilityController::accessibleElementById() is needed since r129308, DragData::droppedFileSystemId() appeared in r120667
Attachments
Patch (2.43 KB, patch)
2013-04-19 02:26 PDT, Alberto Garcia 		cgarcia: review-
cgarcia: commit-queue-
DetailsFormatted DiffDiff
Patch (1.21 KB, patch)
2013-04-22 01:35 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-04-19 02:26:54 PDT
Created attachment 198828 [details] Patch
Carlos Garcia Campos
Comment 2 2013-04-22 00:49:09 PDT
Comment on attachment 198828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198828&action=review > Source/WebCore/platform/blackberry/DragDataBlackBerry.cpp:99 > +String DragData::droppedFileSystemId() const > +{ > + notImplemented(); > + return String(); > +} This should be inside a #if ENABLE(FILE_SYSTEM) block.
Alberto Garcia
Comment 3 2013-04-22 01:30:11 PDT
Ok, I'll also split the patch in two.
Alberto Garcia
Comment 4 2013-04-22 01:35:54 PDT
Created attachment 198999 [details] Patch
WebKit Commit Bot
Comment 5 2013-04-22 02:57:23 PDT
Comment on attachment 198999 [details] Patch Clearing flags on attachment: 198999 Committed r148870: <http://trac.webkit.org/changeset/148870>
WebKit Commit Bot
Comment 6 2013-04-22 02:57:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.