Bug 114860

Summary: [BlackBerry] Remove implementation of ContextMenu classes
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, mifenton, rwlbuis, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 111729    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Alberto Garcia 2013-04-19 02:16:54 PDT 
Although in the BlackBerry port a PlatformMenuDescription is actually a void*, the definition of the method should match that of the parent class.
Comment 1 Alberto Garcia 2013-04-19 02:17:53 PDT 
Created attachment 198827 [details]
Patch
Comment 2 Alberto Garcia 2013-04-19 02:35:16 PDT 
Comment on attachment 198827 [details]
Patch

This patch is actually incomplete, I'll upload a new one.
Comment 3 Alberto Garcia 2013-04-19 05:35:09 PDT 
Updating bug title since a few more changes are needed.
Comment 4 Alberto Garcia 2013-04-19 05:39:22 PDT 
Created attachment 198845 [details]
Patch
Comment 5 Alberto Garcia 2013-06-10 02:19:17 PDT 
We are finally not going to use this, so we can safely remove this code.
Comment 6 Alberto Garcia 2013-06-10 02:21:11 PDT 
Created attachment 204143 [details]
Patch
Comment 7 Rob Buis 2013-06-14 12:37:40 PDT 
Comment on attachment 204143 [details]
Patch

LGTM. Will obviously bring a small speedup in build time :)
Comment 8 WebKit Commit Bot 2013-06-14 13:03:01 PDT 
Comment on attachment 204143 [details]
Patch

Clearing flags on attachment: 204143

Committed r151603: <http://trac.webkit.org/changeset/151603>
Comment 9 WebKit Commit Bot 2013-06-14 13:03:05 PDT 
All reviewed patches have been landed.  Closing bug.