Bug 114817

Summary: Remove obsolete macros from libpng
Product: WebKit Reporter: Alberto Garcia <berto>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alberto Garcia
Reported 2013-04-18 09:04:41 PDT
PNGImageEncoder.cpp uses png_voidp_NULL and png_error_ptr_NULL, which no longer exist in libpng 1.4. From the changelog: b. We removed the typecasted NULL definitions such as #define png_voidp_NULL (png_voidp)NULL If you used these in your application, just use NULL instead. http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summary.txt
Attachments
Patch (1.36 KB, patch)
2013-04-18 09:07 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Patch (1.36 KB, patch)
2013-04-18 09:14 PDT, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-04-18 09:07:14 PDT
Created attachment 198741 [details] Patch
Alberto Garcia
Comment 2 2013-04-18 09:14:22 PDT
Created attachment 198742 [details] Patch There was a typo in the changelog message.
WebKit Commit Bot
Comment 3 2013-04-18 14:00:11 PDT
Comment on attachment 198742 [details] Patch Clearing flags on attachment: 198742 Committed r148701: <http://trac.webkit.org/changeset/148701>
WebKit Commit Bot
Comment 4 2013-04-18 14:00:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.