Bug 114806

Summary:

[EFL][WK2] Change inadequate return value in method setDone().

Product:

WebKit

Reporter:

Krzysztof Wolanski <k.wolanski>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, lucas.de.marchi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
proposed patch	none
added [WK2] tag	none

Description Krzysztof Wolanski 2013-04-18 03:54:41 PDT

Fix possible warning in EFL port: no return statement in function returning non-void. Change return value from bool to void in method setDone().

Comment 1 Krzysztof Wolanski 2013-04-18 04:50:08 PDT

Created attachment 198721 [details]
proposed patch

Comment 2 Chris Dumez 2013-04-18 05:01:26 PDT

Comment on attachment 198721 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198721&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] Change inadequate return value in method setDone().

LGTM but you should add [WK2] tag.

Comment 3 Krzysztof Wolanski 2013-04-18 05:21:01 PDT

Created attachment 198723 [details]
proposed patch

Comment 4 Krzysztof Wolanski 2013-04-18 05:26:27 PDT

Created attachment 198724 [details]
added [WK2] tag

Comment 5 Andreas Kling 2013-04-18 05:38:30 PDT

Comment on attachment 198724 [details]
added [WK2] tag

rs=me

Comment 6 WebKit Commit Bot 2013-04-18 06:07:06 PDT

Comment on attachment 198724 [details]
added [WK2] tag

Clearing flags on attachment: 198724

Committed r148671: <http://trac.webkit.org/changeset/148671>

Comment 7 WebKit Commit Bot 2013-04-18 06:07:09 PDT

All reviewed patches have been landed.  Closing bug.