Bug 114782

Summary: JSC: Workaround limited jump range on some CPU architectures
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, fpizlo, ggaren, jbriance, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the fix. ddkilzer: review+

Mark Lam
Reported 2013-04-17 20:04:00 PDT
My recent change in https://bugs.webkit.org/show_bug.cgi?id=114577 introduced a "btpnz" to a branch target that is out of reach for some CPU architectures. In this case, it's simple enough to introduce the use of a jump island, and that saves us from having to change a whole bunch of CPU specific code. It works out to be a more optimal too. Patch coming soon.
Attachments
the fix. (2.70 KB, patch)
2013-04-17 20:07 PDT, Mark Lam 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-04-17 20:07:31 PDT
Created attachment 198672 [details] the fix.
David Kilzer (:ddkilzer)
Comment 2 2013-04-17 20:13:14 PDT
Comment on attachment 198672 [details] the fix. r=me with help from Mark to make sure I understood the change.
Mark Lam
Comment 3 2013-04-17 20:16:58 PDT
Thanks for the review. Landed in r148655: <http://trac.webkit.org/changeset/148655>.
Note You need to log in before you can comment on or make changes to this bug.