Bug 114737 – REGRESSION(r148588): It broke the Qt WK2 EWS

• Component: New Bugs
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

Fix is coming soon.

[Csaba Osztrogonác]

Created attachment 198503 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 198503 [details]
Patch

I can't say that this all makes sense to me but I don't see anything obviously wrong, rs=me.

[Csaba Osztrogonác]

Comment on attachment 198503 [details]
Patch

Clearing flags on attachment: 198503

Committed r148608: <http://trac.webkit.org/changeset/148608>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

The patch makes sense. What doesn't make sense is that r148588 broke this. How did Qt WK2 EWS work before r148588 without qt-wk2 being defined there?

[Csaba Osztrogonác]

(In reply to comment #5)
> The patch makes sense. What doesn't make sense is that r148588 broke this. How did Qt WK2 EWS work before r148588 without qt-wk2 being defined there?

qt-wk2 didn't exist as platform before. Qt EWS and Qt WK2 EWS 
used qt platform, and only the local BUILD_WEBKIT_ARGS=--no-webkit2
on Qt EWS ensured that it built only WebKit1.

[Ryosuke Niwa]

(In reply to comment #6)
> (In reply to comment #5)
> > The patch makes sense. What doesn't make sense is that r148588 broke this. How did Qt WK2 EWS work before r148588 without qt-wk2 being defined there?
> 
> qt-wk2 didn't exist as platform before. Qt EWS and Qt WK2 EWS 
> used qt platform, and only the local BUILD_WEBKIT_ARGS=--no-webkit2
> on Qt EWS ensured that it built only WebKit1.

Interesting. How did that break with r148588?

[Csaba Osztrogonác]

Comment on attachment 198503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198503&action=review

> Tools/Scripts/webkitpy/common/config/ews.json:33
>      "Qt WK2 EWS": {
> -        "port": "qt",
> +        "port": "qt-wk2",

(In reply to comment #7)
> Interesting. How did that break with r148588?

Before r148588 port and name was different:
Qt EWS: port=qt and name=qt-ews
Qt WK2 EWS: port=qt and name=qt-wk2-ews

after r148588: name=port+"-ews"

r148588 revealed that the previous implementation was misleading,
and I thought it is high time to have a qt-wk2 platform and fix
it properly and get rid one more local hack on the EWS bot. :)

And additionally the change landed from this bug is necessary 
if once Qt want to run tests on the WK1 and/or the WK2 EWS bots.

[Ryosuke Niwa]

Makes sense. Thanks for the clarification & the fix.

We should really merge deprecated ports & new ports :(

[Zoltan Arvai]

Bad window, sorry for the noise.