Bug 114737

Summary: REGRESSION(r148588): It broke the Qt WK2 EWS
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: benjamin, commit-queue, dpranke, hausmann, jturcotte, kadam, ossy, rniwa, zarvai
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 114558    
Attachments:
Description Flags
Patch none

Description Csaba Osztrogonác 2013-04-17 06:28:51 PDT
Fix is coming soon.
Comment 1 Csaba Osztrogonác 2013-04-17 06:48:51 PDT
Created attachment 198503 [details]
Patch
Comment 2 Jocelyn Turcotte 2013-04-17 07:00:28 PDT
Comment on attachment 198503 [details]
Patch

I can't say that this all makes sense to me but I don't see anything obviously wrong, rs=me.
Comment 3 Csaba Osztrogonác 2013-04-17 07:03:53 PDT
Comment on attachment 198503 [details]
Patch

Clearing flags on attachment: 198503

Committed r148608: <http://trac.webkit.org/changeset/148608>
Comment 4 Csaba Osztrogonác 2013-04-17 07:03:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryosuke Niwa 2013-04-17 09:55:00 PDT
The patch makes sense. What doesn't make sense is that r148588 broke this. How did Qt WK2 EWS work before r148588 without qt-wk2 being defined there?
Comment 6 Csaba Osztrogonác 2013-04-17 09:58:04 PDT
(In reply to comment #5)
> The patch makes sense. What doesn't make sense is that r148588 broke this. How did Qt WK2 EWS work before r148588 without qt-wk2 being defined there?

qt-wk2 didn't exist as platform before. Qt EWS and Qt WK2 EWS 
used qt platform, and only the local BUILD_WEBKIT_ARGS=--no-webkit2
on Qt EWS ensured that it built only WebKit1.
Comment 7 Ryosuke Niwa 2013-04-17 10:00:26 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > The patch makes sense. What doesn't make sense is that r148588 broke this. How did Qt WK2 EWS work before r148588 without qt-wk2 being defined there?
> 
> qt-wk2 didn't exist as platform before. Qt EWS and Qt WK2 EWS 
> used qt platform, and only the local BUILD_WEBKIT_ARGS=--no-webkit2
> on Qt EWS ensured that it built only WebKit1.

Interesting. How did that break with r148588?
Comment 8 Csaba Osztrogonác 2013-04-17 10:08:02 PDT
Comment on attachment 198503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198503&action=review

> Tools/Scripts/webkitpy/common/config/ews.json:33
>      "Qt WK2 EWS": {
> -        "port": "qt",
> +        "port": "qt-wk2",

(In reply to comment #7)
> Interesting. How did that break with r148588?

Before r148588 port and name was different:
Qt EWS: port=qt and name=qt-ews
Qt WK2 EWS: port=qt and name=qt-wk2-ews

after r148588: name=port+"-ews"

r148588 revealed that the previous implementation was misleading,
and I thought it is high time to have a qt-wk2 platform and fix
it properly and get rid one more local hack on the EWS bot. :)

And additionally the change landed from this bug is necessary 
if once Qt want to run tests on the WK1 and/or the WK2 EWS bots.
Comment 9 Ryosuke Niwa 2013-04-17 10:15:07 PDT
Makes sense. Thanks for the clarification & the fix.

We should really merge deprecated ports & new ports :(
Comment 10 Zoltan Arvai 2013-04-18 01:22:26 PDT
Bad window, sorry for the noise.