Bug 114727

Summary:

Gradient: add PlatformGradient definition for BlackBerry

Product:

WebKit

Reporter:

Alberto Garcia <berto>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

111729

Attachments:

Description	Flags
Patch	cgarcia: review-, cgarcia: commit-queue-
Patch	none

Description Alberto Garcia 2013-04-17 02:16:24 PDT

PlatformGradient is not defined for BlackBerry in Gradient.h

Comment 1 Alberto Garcia 2013-04-17 02:17:34 PDT

Created attachment 198486 [details]
Patch

Comment 2 Carlos Garcia Campos 2013-04-22 00:55:51 PDT

Comment on attachment 198486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198486&action=review

> Source/WebCore/platform/graphics/Gradient.h:62
> +    class Gradient;

This should not be indented, I wonder why the the style checker hasn't caught this, maybe because of the multiple namespaces in the same line which is not common in WebKit code either.

Comment 3 Alberto Garcia 2013-04-22 01:11:05 PDT

Created attachment 198997 [details]
Patch

Here's the updated patch.

Comment 4 WebKit Commit Bot 2013-04-22 01:58:09 PDT

Comment on attachment 198997 [details]
Patch

Clearing flags on attachment: 198997

Committed r148864: <http://trac.webkit.org/changeset/148864>

Comment 5 WebKit Commit Bot 2013-04-22 01:58:11 PDT

All reviewed patches have been landed.  Closing bug.