| Summary: | Web Inspector: make generate-inspector-protocol-version work with python3 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Correia (qrwteyrutiyoup) <sergio> | ||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sergio Correia (qrwteyrutiyoup)
2013-04-16 18:14:02 PDT
Created attachment 198456 [details]
Patch
Proposed patch
Comment on attachment 198456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198456&action=review Looks good. Just get that typo in the ChangeLog fixed if possible! > Source/WebCore/ChangeLog:10 > + to the sys.stderr.write() ones already used througout the file. Typo: "througout" => "throughout" Created attachment 198459 [details]
Patch
Typo fixed in changelog and commit message.
Comment on attachment 198459 [details]
Patch
I assume this works with older python versions still?
(In reply to comment #4) > (From update of attachment 198459 [details]) > I assume this works with older python versions still? Yup, it keeps working with python2 as expected, since that is what is officially supported. I had some odd setup in here when it crashed on me, and since I saw revision https://bugs.webkit.org/show_bug.cgi?id=106194, I thought to keep it working with python3, assuming someone uses it somehow. All in all, this patch merely makes the file more consistent, since we already have sys.stderr.write, and now sys.stdout.write too. Comment on attachment 198459 [details]
Patch
Thanks!
Comment on attachment 198459 [details] Patch Clearing flags on attachment: 198459 Committed r148630: <http://trac.webkit.org/changeset/148630> All reviewed patches have been landed. Closing bug. |