| Summary: | Harden FastMalloc against partial pointer overflows | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||
| Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cmarcelo, commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Oliver Hunt
2013-04-16 17:39:14 PDT
Created attachment 198455 [details]
Patch
Attachment 198455 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FastMalloc.cpp']" exit_code: 1
Source/WTF/wtf/FastMalloc.cpp:3993: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:3994: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:3995: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:3997: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WTF/wtf/FastMalloc.cpp:4010: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 5 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 198455 [details]
Patch
preemptive RS=me for a patch the renames the random characters to proper variable names.
Committed r148587: <http://trac.webkit.org/changeset/148587> |