Bug 114711

Summary: REGRESSION(r148545): Broke non-Mac builds and broke spellchecking tests on Mac (Requested by rniwa on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abecsi, aboxhall, allan.jensen, andersca, apinheiro, cfleizach, cmarcelo, dbates, dmazzoni, d-r, eric.carlson, esprehn+autocc, fmalita, gyuyoung.kim, japhet, jdiggs, jer.noble, menard, mifenton, pdr, rakuco, rniwa, sam, schenney, simon.fraser, tkent, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 114642    
Attachments:
Description Flags
ROLLOUT of r148545 none

WebKit Commit Bot
Reported 2013-04-16 15:46:47 PDT
http://trac.webkit.org/changeset/148545 broke the build: Broke non-Mac builds and broke spellchecking tests on Mac (Requested by rniwa on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r148545 (60.78 KB, patch)
2013-04-16 15:47 PDT, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2013-04-16 15:47:10 PDT
Created attachment 198449 [details] ROLLOUT of r148545 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
WebKit Commit Bot
Comment 2 2013-04-16 15:49:32 PDT
Attachment 198449 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/SpellChecker.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/html/shadow/ClearButtonElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/FrameView.h', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/page/win/FrameCGWin.cpp', u'Source/WebCore/page/win/FrameWin.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/qt/ClipboardQt.cpp', u'Source/WebCore/platform/win/DragDataWin.cpp', u'Source/WebCore/platform/win/PasteboardWin.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/WebViewInputMethodFilter.cpp', u'Source/WebKit/gtk/webkit/webkitwebframe.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/DragClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp']" exit_code: 1 Source/WebCore/rendering/RenderEmbeddedObject.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/dom/ContainerNode.cpp:48: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/dom/ContainerNode.cpp:59: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/WebProcess/Plugins/PluginView.cpp:43: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/history/CachedFrame.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/history/CachedFrame.cpp:48: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/loader/FrameLoader.cpp:42: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 7 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Note You need to log in before you can comment on or make changes to this bug.