Bug 114697

Summary: PlugIns that resize in user gestures should be immune to snapshotting
Product: WebKit Reporter: Dean Jackson <dino>
Component: Plug-insAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Dean Jackson
Reported 2013-04-16 13:15:12 PDT
https://bugs.webkit.org/show_bug.cgi?id=102157 introduced detecting if a plugin resizes above the snapshotting threshold. But plugins that do this in response to user gestures should not snapshot.
Attachments
Patch (3.41 KB, patch)
2013-04-16 13:59 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-04-16 13:15:42 PDT
<rdar://problem/13666258>
Dean Jackson
Comment 2 2013-04-16 13:59:16 PDT
Created attachment 198426 [details] Patch
Tim Horton
Comment 3 2013-04-16 14:00:44 PDT
Comment on attachment 198426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198426&action=review > Source/WebCore/html/HTMLPlugInImageElement.cpp:556 > + if (!m_needsCheckForSizeChange || m_snapshotDecision != MaySnapshotWhenResized || wasRecentUserGesture(document())) the document was not a recent user gesture. perhaps had* or saw*?
Dean Jackson
Comment 4 2013-04-16 14:57:18 PDT
Changed to documentHadRecentUserGesture
Dean Jackson
Comment 5 2013-04-16 15:00:56 PDT
https://trac.webkit.org/r148547
Note You need to log in before you can comment on or make changes to this bug.