Bug 114697

Summary: PlugIns that resize in user gestures should be immune to snapshotting
Product: WebKit Reporter: Dean Jackson <dino>
Component: Plug-insAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Dean Jackson 2013-04-16 13:15:12 PDT
https://bugs.webkit.org/show_bug.cgi?id=102157 introduced detecting if a plugin resizes above the snapshotting threshold. But plugins that do this in response to user gestures should not snapshot.
Comment 1 Radar WebKit Bug Importer 2013-04-16 13:15:42 PDT
<rdar://problem/13666258>
Comment 2 Dean Jackson 2013-04-16 13:59:16 PDT
Created attachment 198426 [details]
Patch
Comment 3 Tim Horton 2013-04-16 14:00:44 PDT
Comment on attachment 198426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198426&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:556
> +    if (!m_needsCheckForSizeChange || m_snapshotDecision != MaySnapshotWhenResized || wasRecentUserGesture(document()))

the document was not a recent user gesture. perhaps had* or saw*?
Comment 4 Dean Jackson 2013-04-16 14:57:18 PDT
Changed to documentHadRecentUserGesture
Comment 5 Dean Jackson 2013-04-16 15:00:56 PDT
https://trac.webkit.org/r148547