Bug 114681

Summary: [refactor] Moved ScriptedAnimationController clearance code to common function
Product: WebKit Reporter: Bruno Abinader (history only) <bruno.abinader>
Component: Layout and RenderingAssignee: Bruno Abinader (history only) <bruno.abinader>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, dbates, esprehn+autocc, jamesr, rego+ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eflews.bot: commit-queue-
Patch none

Bruno Abinader (history only)
Reported 2013-04-16 05:59:29 PDT
Avoided duplicated code by moving ScriptedAnimationController clearance code to an inline function to be used by both Document::dispose() and Document::detach().
Attachments
Patch (3.60 KB, patch)
2013-04-16 06:02 PDT, Bruno Abinader (history only) 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (3.04 KB, patch)
2013-04-16 06:39 PDT, Bruno Abinader (history only) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bruno Abinader (history only)
Comment 1 2013-04-16 06:02:35 PDT
Created attachment 198320 [details] Patch
EFL EWS Bot
Comment 2 2013-04-16 06:10:12 PDT
Comment on attachment 198320 [details] Patch Attachment 198320 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/171013
Bruno Abinader (history only)
Comment 3 2013-04-16 06:39:16 PDT
Created attachment 198327 [details] Patch Moved implementation code out of header as ScriptedAnimationController is forward declared in Document.cpp source.
WebKit Commit Bot
Comment 4 2013-04-17 11:15:34 PDT
Comment on attachment 198327 [details] Patch Clearing flags on attachment: 198327 Committed r148618: <http://trac.webkit.org/changeset/148618>
WebKit Commit Bot
Comment 5 2013-04-17 11:15:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.