Summary: | The list of contributors in committers.py should be a separate JSON | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue, dpranke, glenn, kling, koivisto, mjs, ossy, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 114671 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-04-16 02:14:46 PDT
This will also allow Bugzilla and other websites and tools to parse the list of contributors in JavaScript more easily. Created attachment 198315 [details]
Cleanup
Comment on attachment 198315 [details]
Cleanup
LGTM, but using email/email and nick/nicks in the JSON is a little bit strange for me.
I prefer a simpler syntax, only email and nick. It is so easy to check if an instance
is a string or a list: isinstance(var, types.ListType) and isinstance(var, types.StringType)
Or we should recommend always using lists. (In reply to comment #4) > Or we should recommend always using lists. Let’s do that. Created attachment 198344 [details]
Always use emails and nicks
Committed r148527: <http://trac.webkit.org/changeset/148527> I notice that completion no longer works in BZ's CC, Assigned To etc, which may have to do with this patch. (In reply to comment #8) > I notice that completion no longer works in BZ's CC, Assigned To etc, which may have to do with this patch. Clear the cache. |