Bug 114673

Summary: The list of contributors in committers.py should be a separate JSON
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, dpranke, glenn, kling, koivisto, mjs, ossy, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 114671    
Bug Blocks:    
Attachments:
Description Flags
Cleanup
none
Always use emails and nicks andersca: review+

Description Ryosuke Niwa 2013-04-16 02:14:46 PDT
We should extract the list of contributors, committers, and reviewers into a JSON file.
There’s no point in forcing everyone to read through Python code.
Comment 1 Ryosuke Niwa 2013-04-16 02:15:38 PDT
This will also allow Bugzilla and other websites and tools to parse the list of contributors in JavaScript more easily.
Comment 2 Ryosuke Niwa 2013-04-16 03:29:30 PDT
Created attachment 198315 [details]
Cleanup
Comment 3 Csaba Osztrogonác 2013-04-16 04:12:46 PDT
Comment on attachment 198315 [details]
Cleanup

LGTM, but using email/email and nick/nicks in the JSON is a little bit strange for me.
I prefer a simpler syntax, only email and nick. It is so easy to check if an instance
is a string or a list: isinstance(var, types.ListType) and isinstance(var, types.StringType)
Comment 4 Csaba Osztrogonác 2013-04-16 04:41:51 PDT
Or we should recommend always using lists.
Comment 5 Ryosuke Niwa 2013-04-16 10:34:33 PDT
(In reply to comment #4)
> Or we should recommend always using lists.

Let’s do that.
Comment 6 Ryosuke Niwa 2013-04-16 10:34:52 PDT
Created attachment 198344 [details]
Always use emails and nicks
Comment 7 Ryosuke Niwa 2013-04-16 11:39:47 PDT
Committed r148527: <http://trac.webkit.org/changeset/148527>
Comment 8 Glenn Adams 2013-04-16 22:20:06 PDT
I notice that completion no longer works in BZ's CC, Assigned To etc, which may have to do with this patch.
Comment 9 Ryosuke Niwa 2013-04-16 22:21:52 PDT
(In reply to comment #8)
> I notice that completion no longer works in BZ's CC, Assigned To etc, which may have to do with this patch.

Clear the cache.