Bug 114641

Summary: ScriptWrappable subclasses shouldn't have to include WeakInlines.h
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, gyuyoung.kim, macpherson, menard, rakuco, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review+, buildbot: commit-queue-

Anders Carlsson
Reported 2013-04-15 14:47:40 PDT
ScriptWrappable subclasses shouldn't have to include WeakInlines.h
Attachments
Patch (18.51 KB, patch)
2013-04-15 16:03 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (20.38 KB, patch)
2013-04-15 16:09 PDT, Anders Carlsson 		ap: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-04-15 16:03:02 PDT
Created attachment 198197 [details] Patch
Anders Carlsson
Comment 2 2013-04-15 16:09:51 PDT
Created attachment 198198 [details] Patch
Build Bot
Comment 3 2013-04-15 16:54:35 PDT
Comment on attachment 198198 [details] Patch Attachment 198198 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/94094
Anders Carlsson
Comment 4 2013-04-15 17:20:37 PDT
Committed r148479: <http://trac.webkit.org/changeset/148479>
Ryosuke Niwa
Comment 5 2013-04-15 20:31:44 PDT
It seems like this patch caused Windows clean builds to fail? e.g. http://webkit-queues.appspot.com/results/146209
Note You need to log in before you can comment on or make changes to this bug.