Bug 114641

Summary:

ScriptWrappable subclasses shouldn't have to include WeakInlines.h

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, gyuyoung.kim, macpherson, menard, rakuco, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ap: review+, buildbot: commit-queue-

Description Anders Carlsson 2013-04-15 14:47:40 PDT

ScriptWrappable subclasses shouldn't have to include WeakInlines.h

Comment 1 Anders Carlsson 2013-04-15 16:03:02 PDT

Created attachment 198197 [details]
Patch

Comment 2 Anders Carlsson 2013-04-15 16:09:51 PDT

Created attachment 198198 [details]
Patch

Comment 3 Build Bot 2013-04-15 16:54:35 PDT

Comment on attachment 198198 [details]
Patch

Attachment 198198 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/94094

Comment 4 Anders Carlsson 2013-04-15 17:20:37 PDT

Committed r148479: <http://trac.webkit.org/changeset/148479>

Comment 5 Ryosuke Niwa 2013-04-15 20:31:44 PDT

It seems like this patch caused Windows clean builds to fail?

e.g. http://webkit-queues.appspot.com/results/146209