Bug 114631

Summary: Remove unneeded headers from ScriptExecutionContext.h
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, buildbot, cmarcelo, commit-queue, danw, d-r, eric.carlson, esprehn+autocc, fmalita, gtk-ews, gustavo, gyuyoung.kim, jer.noble, luiz, mifenton, mrobinson, noam, pdr, rakuco, rego+ews, rniwa, schenney, tkent, WebkitBugTracker, webkit-ews, xan.lopez, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch sam: review+

Anders Carlsson
Reported 2013-04-15 13:01:29 PDT
Remove unneeded headers from ScriptExecutionContext.h
Attachments
Patch (23.67 KB, patch)
2013-04-15 13:06 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (25.43 KB, patch)
2013-04-15 13:13 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (26.06 KB, patch)
2013-04-15 17:37 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (27.07 KB, patch)
2013-04-15 18:16 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (27.65 KB, patch)
2013-04-16 11:13 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-04-15 13:06:17 PDT
Created attachment 198172 [details] Patch
Anders Carlsson
Comment 2 2013-04-15 13:13:42 PDT
Created attachment 198176 [details] Patch
Early Warning System Bot
Comment 3 2013-04-15 13:54:02 PDT
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/57461
Early Warning System Bot
Comment 4 2013-04-15 13:55:11 PDT
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-queues.appspot.com/results/114206
Build Bot
Comment 5 2013-04-15 13:55:19 PDT
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/119192
EFL EWS Bot
Comment 6 2013-04-15 14:08:20 PDT
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/57466
Build Bot
Comment 7 2013-04-15 14:20:06 PDT
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/8211
kov's GTK+ EWS bot
Comment 8 2013-04-15 14:43:17 PDT
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/57478
Alexey Proskuryakov
Comment 9 2013-04-15 14:46:36 PDT
Comment on attachment 198176 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198176&action=review r=me once everything is green. > Source/WebCore/dom/ScriptExecutionContext.h:54 > +typedef JSC::ExecState ScriptState; Can we move ScriptStateProtectedPtr into a separate header from ScriptState.h instead?
Build Bot
Comment 10 2013-04-15 15:05:52 PDT
Comment on attachment 198176 [details] Patch Attachment 198176 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/110246
Anders Carlsson
Comment 11 2013-04-15 17:37:21 PDT
Created attachment 198206 [details] Patch
Anders Carlsson
Comment 12 2013-04-15 17:42:29 PDT
(In reply to comment #9) > (From update of attachment 198176 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=198176&action=review > > r=me once everything is green. > > > Source/WebCore/dom/ScriptExecutionContext.h:54 > > +typedef JSC::ExecState ScriptState; > > Can we move ScriptStateProtectedPtr into a separate header from ScriptState.h instead? I think we can just get rid of ScriptStateProtectedPtr - it’s one of the many V8 abstractions that are no longer needed.
Anders Carlsson
Comment 13 2013-04-15 18:16:23 PDT
Created attachment 198212 [details] Patch
kov's GTK+ EWS bot
Comment 14 2013-04-15 22:49:24 PDT
Comment on attachment 198212 [details] Patch Attachment 198212 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/160029
Anders Carlsson
Comment 15 2013-04-16 11:13:11 PDT
Created attachment 198346 [details] Patch
Anders Carlsson
Comment 16 2013-04-16 12:56:21 PDT
Committed r148536: <http://trac.webkit.org/changeset/148536>
Nico Weber
Comment 17 2013-04-16 22:39:36 PDT
Comment on attachment 198346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198346&action=review > Source/WebCore/dom/ScriptExecutionContext.h:-43 > -#include <wtf/PassOwnPtr.h> (OwnPtr and PassOwnPtr are used in this .h file, so they are somehow included anyways.)
Allan Sandfeld Jensen
Comment 18 2013-04-17 06:17:28 PDT
This broke the build on the Qt Windows 32bit Debug bot.
Note You need to log in before you can comment on or make changes to this bug.