Bug 114621

Summary: Initialize logging channels for web processes
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: PlatformAssignee: Balazs Kelemen <kbalazs>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cgarcia, cmarcelo, commit-queue, gyuyoung.kim, jturcotte, menard, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Balazs Kelemen
Reported 2013-04-15 05:49:27 PDT
Yet another trick to make debugging WebKit2 even more fun.
Attachments
Patch (5.92 KB, patch)
2013-04-15 06:05 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (7.22 KB, patch)
2013-04-16 01:40 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2013-04-15 06:05:14 PDT
Created attachment 198119 [details] Patch
Alexey Proskuryakov
Comment 2 2013-04-15 11:36:38 PDT
Comment on attachment 198119 [details] Patch Looks OK. Where do you initialize WebKit2 logging channels though, why are they not together? This is what we have on Mac: #if !LOG_DISABLED WebCore::initializeLoggingChannelsIfNecessary(); WebKit::initializeLogChannelsIfNecessary(); #endif // !LOG_DISABLED
Balazs Kelemen
Comment 3 2013-04-16 01:39:03 PDT
(In reply to comment #2) > (From update of attachment 198119 [details]) > Looks OK. Where do you initialize WebKit2 logging channels though, why are they not together? This is what we have on Mac: > > #if !LOG_DISABLED > WebCore::initializeLoggingChannelsIfNecessary(); > WebKit::initializeLogChannelsIfNecessary(); > #endif // !LOG_DISABLED I searched for but did not find this code. It seems to be a better solution to use this shared code for every initialization.
Balazs Kelemen
Comment 4 2013-04-16 01:40:02 PDT
Created attachment 198276 [details] Patch
Balazs Kelemen
Comment 5 2013-04-22 02:11:42 PDT
Comment on attachment 198276 [details] Patch Landed in 148519
Note You need to log in before you can comment on or make changes to this bug.