Bug 114621

Summary: Initialize logging channels for web processes
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: PlatformAssignee: Balazs Kelemen <kbalazs>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cgarcia, cmarcelo, commit-queue, gyuyoung.kim, jturcotte, menard, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Balazs Kelemen 2013-04-15 05:49:27 PDT
Yet another trick to make debugging WebKit2 even more fun.
Comment 1 Balazs Kelemen 2013-04-15 06:05:14 PDT
Created attachment 198119 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-04-15 11:36:38 PDT
Comment on attachment 198119 [details]
Patch

Looks OK. Where do you initialize WebKit2 logging channels though, why are they not together? This is what we have on Mac:

#if !LOG_DISABLED
    WebCore::initializeLoggingChannelsIfNecessary();
    WebKit::initializeLogChannelsIfNecessary();
#endif // !LOG_DISABLED
Comment 3 Balazs Kelemen 2013-04-16 01:39:03 PDT
(In reply to comment #2)
> (From update of attachment 198119 [details])
> Looks OK. Where do you initialize WebKit2 logging channels though, why are they not together? This is what we have on Mac:
> 
> #if !LOG_DISABLED
>     WebCore::initializeLoggingChannelsIfNecessary();
>     WebKit::initializeLogChannelsIfNecessary();
> #endif // !LOG_DISABLED

I searched for but did not find this code. It seems to be a better solution to use this shared code for every initialization.
Comment 4 Balazs Kelemen 2013-04-16 01:40:02 PDT
Created attachment 198276 [details]
Patch
Comment 5 Balazs Kelemen 2013-04-22 02:11:42 PDT
Comment on attachment 198276 [details]
Patch

Landed in 148519