Summary: | Initialize logging channels for web processes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> | ||||||
Component: | Platform | Assignee: | Balazs Kelemen <kbalazs> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abecsi, cgarcia, cmarcelo, commit-queue, gyuyoung.kim, jturcotte, menard, rakuco | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Balazs Kelemen
2013-04-15 05:49:27 PDT
Created attachment 198119 [details]
Patch
Comment on attachment 198119 [details]
Patch
Looks OK. Where do you initialize WebKit2 logging channels though, why are they not together? This is what we have on Mac:
#if !LOG_DISABLED
WebCore::initializeLoggingChannelsIfNecessary();
WebKit::initializeLogChannelsIfNecessary();
#endif // !LOG_DISABLED
(In reply to comment #2) > (From update of attachment 198119 [details]) > Looks OK. Where do you initialize WebKit2 logging channels though, why are they not together? This is what we have on Mac: > > #if !LOG_DISABLED > WebCore::initializeLoggingChannelsIfNecessary(); > WebKit::initializeLogChannelsIfNecessary(); > #endif // !LOG_DISABLED I searched for but did not find this code. It seems to be a better solution to use this shared code for every initialization. Created attachment 198276 [details]
Patch
Comment on attachment 198276 [details]
Patch
Landed in 148519
|