Bug 114598

Summary:

Remove unused AlternativeTextClient::dismissDictationAlternativeUI

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebCore Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, enrica, jiapu.mail, mifenton, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Alexey Proskuryakov

Reported 2013-04-14 17:38:03 PDT

AlternativeTextClient::dismissDictationAlternativeUI is never called. It hasn't been touched in a long time, so it looks more like dead code than part of a plan in progress.

Attachments
proposed patch (13.02 KB, patch) 2013-04-14 17:40 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2013-04-14 17:40:50 PDT

Created attachment 198017 [details] proposed patch I do not know much about this code, so if you are aware of a reason to keep this function, please tell.

Jia Pu

Comment 2 2013-04-15 17:57:46 PDT

This function can be removed, since dismissal of both correction and dictionary alternative is done by WebAlterantiveTextClient::dismissAlternative() in both WK and WK2.

WebKit Commit Bot

Comment 3 2013-04-16 11:54:56 PDT

Comment on attachment 198017 [details] proposed patch Clearing flags on attachment: 198017 Committed r148531: <http://trac.webkit.org/changeset/148531>

WebKit Commit Bot

Comment 4 2013-04-16 11:54:58 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.