Bug 114575

Summary: Add form delegate method that's invoked right before sending a submit event to a form element
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Description Anders Carlsson 2013-04-13 14:39:12 PDT
Add form delegate method that's invoked right before sending a submit event to a form element
Comment 1 Anders Carlsson 2013-04-13 14:42:28 PDT
Created attachment 197956 [details]
Patch
Comment 2 mitz 2013-04-13 14:51:24 PDT
Comment on attachment 197956 [details]
Patch

Looks good, but you should add API tests or explain why this can’t be tested.
Comment 3 Anders Carlsson 2013-04-13 15:16:27 PDT
Created attachment 197959 [details]
Patch
Comment 4 mitz 2013-04-13 15:20:28 PDT
Comment on attachment 197959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197959&action=review

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:960
> +			attributes = {
> +			};

Weird

> Tools/TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:29
> +#include "PlatformUtilities.h"
> +#include "PlatformWebView.h"
> +#include "Test.h"

#import, not #include
Comment 5 Anders Carlsson 2013-04-13 15:27:09 PDT
Committed r148368: <http://trac.webkit.org/changeset/148368>