Bug 114575 - Add form delegate method that's invoked right before sending a submit event to a form element
Summary: Add form delegate method that's invoked right before sending a submit event t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-13 14:39 PDT by Anders Carlsson
Modified: 2013-04-13 15:27 PDT (History)
1 user (show)

See Also:

Attachments
Patch (12.37 KB, patch)
2013-04-13 14:42 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (21.18 KB, patch)
2013-04-13 15:16 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-04-13 14:39:12 PDT 
Add form delegate method that's invoked right before sending a submit event to a form element
Comment 1 Anders Carlsson 2013-04-13 14:42:28 PDT 
Created attachment 197956 [details]
Patch
Comment 2 mitz 2013-04-13 14:51:24 PDT 
Comment on attachment 197956 [details]
Patch

Looks good, but you should add API tests or explain why this can’t be tested.
Comment 3 Anders Carlsson 2013-04-13 15:16:27 PDT 
Created attachment 197959 [details]
Patch
Comment 4 mitz 2013-04-13 15:20:28 PDT 
Comment on attachment 197959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197959&action=review

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:960
> +			attributes = {
> +			};

Weird

> Tools/TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:29
> +#include "PlatformUtilities.h"
> +#include "PlatformWebView.h"
> +#include "Test.h"

#import, not #include
Comment 5 Anders Carlsson 2013-04-13 15:27:09 PDT 
Committed r148368: <http://trac.webkit.org/changeset/148368>