WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
114575
Add form delegate method that's invoked right before sending a submit event to a form element
https://bugs.webkit.org/show_bug.cgi?id=114575
Summary
Add form delegate method that's invoked right before sending a submit event t...
Anders Carlsson
Reported
2013-04-13 14:39:12 PDT
Add form delegate method that's invoked right before sending a submit event to a form element
Attachments
Patch
(12.37 KB, patch)
2013-04-13 14:42 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
Patch
(21.18 KB, patch)
2013-04-13 15:16 PDT
,
Anders Carlsson
mitz: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2013-04-13 14:42:28 PDT
Created
attachment 197956
[details]
Patch
mitz
Comment 2
2013-04-13 14:51:24 PDT
Comment on
attachment 197956
[details]
Patch Looks good, but you should add API tests or explain why this can’t be tested.
Anders Carlsson
Comment 3
2013-04-13 15:16:27 PDT
Created
attachment 197959
[details]
Patch
mitz
Comment 4
2013-04-13 15:20:28 PDT
Comment on
attachment 197959
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=197959&action=review
> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:960 > + attributes = { > + };
Weird
> Tools/TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:29 > +#include "PlatformUtilities.h" > +#include "PlatformWebView.h" > +#include "Test.h"
#import, not #include
Anders Carlsson
Comment 5
2013-04-13 15:27:09 PDT
Committed
r148368
: <
http://trac.webkit.org/changeset/148368
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug