Bug 114561

Summary:

REGRESSION(r148128): window.resizeTo doesn't work from Safari address bar.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore JavaScript

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kevin, kling

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	sam: review+

Description Andreas Kling 2013-04-13 04:50:18 PDT

<rdar://problem/13635894>

Comment 1 Andreas Kling 2013-04-13 07:11:14 PDT

Created attachment 197936 [details]
Proposed patch

Comment 2 Alexey Proskuryakov 2013-04-13 19:38:18 PDT

Comment on attachment 197936 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197936&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore::DOMWindow::canChangeWindowGeometry):

Drive-by comment: this looks like a "may" or "allowedTo" function, not a "can" one.

Comment 3 Sam Weinig 2013-04-14 15:45:44 PDT

Comment on attachment 197936 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197936&action=review

Can this be tested?

> Source/WebCore/page/DOMWindow.cpp:1449
> +bool DOMWindow::canChangeWindowGeometry() const

I agree with Alexey, something like allowedToChangeWindowGeometry would be more clear.  This could also use a comment.

Comment 4 Alexey Proskuryakov 2013-04-15 11:41:46 PDT

*** Bug 114445 has been marked as a duplicate of this bug. ***

Comment 5 Andreas Kling 2013-04-16 03:04:19 PDT

Committed r148508: <http://trac.webkit.org/changeset/148508>