Bug 114557

Summary: [CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Patrick R. Gansterer 2013-04-13 02:55:59 PDT 
[CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt
Comment 1 Patrick R. Gansterer 2013-04-13 03:00:01 PDT 
Created attachment 197929 [details]
Patch
Comment 2 Brent Fulgham 2013-04-15 12:58:10 PDT 
Comment on attachment 197929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197929&action=review

> Source/WTF/wtf/CMakeLists.txt:178
> +    NullPtr.cpp

Is this not needed by any other platform build?  E.g., the Windows 2005 build (were it on CMake) would need this as well.
Comment 3 Patrick R. Gansterer 2013-04-15 16:21:29 PDT 
Comment on attachment 197929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197929&action=review

>> Source/WTF/wtf/CMakeLists.txt:178
>> +    NullPtr.cpp
> 
> Is this not needed by any other platform build?  E.g., the Windows 2005 build (were it on CMake) would need this as well.

now it is in the files for all compilers, so VS2005 will see it too
Comment 4 Laszlo Gombos 2013-04-22 20:05:28 PDT 
Comment on attachment 197929 [details]
Patch

r=me.
Comment 5 WebKit Commit Bot 2013-04-22 20:31:33 PDT 
Comment on attachment 197929 [details]
Patch

Clearing flags on attachment: 197929

Committed r148941: <http://trac.webkit.org/changeset/148941>
Comment 6 WebKit Commit Bot 2013-04-22 20:31:36 PDT 
All reviewed patches have been landed.  Closing bug.