| Summary: | [CMake] Add WTF_USE_*_UNICODE variables | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
| Component: | Tools / Tests | Assignee: | Patrick R. Gansterer <paroga> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cmarcelo, commit-queue, gyuyoung.kim, rakuco, rniwa, roger_fong | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Patrick R. Gansterer
2013-04-13 02:47:06 PDT
Created attachment 197928 [details]
Patch
Comment on attachment 197928 [details]
Patch
r=me
Comment on attachment 197928 [details] Patch Clearing flags on attachment: 197928 Committed r148463: <http://trac.webkit.org/changeset/148463> All reviewed patches have been landed. Closing bug. It seems like this patch broke Windows clean build: http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47545/steps/compile-webkit/logs/stdio 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_foldCase referenced in function "int __cdecl WTF::Unicode::foldCase(int)" (?foldCase@Unicode@WTF@@YAHH@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_strFoldCase referenced in function "int __cdecl WTF::Unicode::foldCase(wchar_t *,int,wchar_t const *,int,bool *)" (?foldCase@Unicode@WTF@@YAHPA_WHPB_WHPA_N@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_strToLower referenced in function "int __cdecl WTF::Unicode::toLower(wchar_t *,int,wchar_t const *,int,bool *)" (?toLower@Unicode@WTF@@YAHPA_WHPB_WHPA_N@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_tolower referenced in function "int __cdecl WTF::Unicode::toLower(int)" (?toLower@Unicode@WTF@@YAHH@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_toupper referenced in function "int __cdecl WTF::Unicode::toUpper(int)" (?toUpper@Unicode@WTF@@YAHH@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_strToUpper referenced in function "int __cdecl WTF::Unicode::toUpper(wchar_t *,int,wchar_t const *,int,bool *)" (?toUpper@Unicode@WTF@@YAHPA_WHPB_WHPA_N@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_charDirection referenced in function "enum WTF::Unicode::Direction __cdecl WTF::Unicode::direction(int)" (?direction@Unicode@WTF@@YA?AW4Direction@12@H@Z) 13>WTF.lib(WTFString.obj) : error LNK2001: unresolved external symbol _u_charDirection 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_memcasecmp referenced in function "int __cdecl WTF::Unicode::umemcasecmp(wchar_t const *,wchar_t const *,int)" (?umemcasecmp@Unicode@WTF@@YAHPB_W0H@Z) (In reply to comment #5) > It seems like this patch broke Windows clean build: > > http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47545/steps/compile-webkit/logs/stdio I don't think so, since this commit changed CMake files only and the Windows bots don't use CMake (yet). |