Bug 114556

Summary:

[CMake] Add WTF_USE_*_UNICODE variables

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Tools / Tests

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, gyuyoung.kim, rakuco, rniwa, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Patrick R. Gansterer

Reported 2013-04-13 02:47:06 PDT

[CMake] Add WTF_USE_*_UNICODE variables

Attachments
Patch (11.18 KB, patch) 2013-04-13 02:52 PDT, Patrick R. Gansterer	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Patrick R. Gansterer

Comment 1 2013-04-13 02:52:51 PDT

Created attachment 197928 [details] Patch

Brent Fulgham

Comment 2 2013-04-15 12:59:17 PDT

Comment on attachment 197928 [details] Patch r=me

WebKit Commit Bot

Comment 3 2013-04-15 13:31:20 PDT

Comment on attachment 197928 [details] Patch Clearing flags on attachment: 197928 Committed r148463: <http://trac.webkit.org/changeset/148463>

WebKit Commit Bot

Comment 4 2013-04-15 13:31:22 PDT

All reviewed patches have been landed. Closing bug.

Ryosuke Niwa

Comment 5 2013-04-15 21:15:23 PDT

It seems like this patch broke Windows clean build: http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47545/steps/compile-webkit/logs/stdio 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_foldCase referenced in function "int __cdecl WTF::Unicode::foldCase(int)" (?foldCase@Unicode@WTF@@YAHH@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_strFoldCase referenced in function "int __cdecl WTF::Unicode::foldCase(wchar_t *,int,wchar_t const *,int,bool *)" (?foldCase@Unicode@WTF@@YAHPA_WHPB_WHPA_N@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_strToLower referenced in function "int __cdecl WTF::Unicode::toLower(wchar_t *,int,wchar_t const *,int,bool *)" (?toLower@Unicode@WTF@@YAHPA_WHPB_WHPA_N@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_tolower referenced in function "int __cdecl WTF::Unicode::toLower(int)" (?toLower@Unicode@WTF@@YAHH@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_toupper referenced in function "int __cdecl WTF::Unicode::toUpper(int)" (?toUpper@Unicode@WTF@@YAHH@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_strToUpper referenced in function "int __cdecl WTF::Unicode::toUpper(wchar_t *,int,wchar_t const *,int,bool *)" (?toUpper@Unicode@WTF@@YAHPA_WHPB_WHPA_N@Z) 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_charDirection referenced in function "enum WTF::Unicode::Direction __cdecl WTF::Unicode::direction(int)" (?direction@Unicode@WTF@@YA?AW4Direction@12@H@Z) 13>WTF.lib(WTFString.obj) : error LNK2001: unresolved external symbol _u_charDirection 13>WTF.lib(StringImpl.obj) : error LNK2019: unresolved external symbol _u_memcasecmp referenced in function "int __cdecl WTF::Unicode::umemcasecmp(wchar_t const *,wchar_t const *,int)" (?umemcasecmp@Unicode@WTF@@YAHPB_W0H@Z)

Patrick R. Gansterer

Comment 6 2013-04-15 22:56:29 PDT

(In reply to comment #5) > It seems like this patch broke Windows clean build: > > http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/47545/steps/compile-webkit/logs/stdio I don't think so, since this commit changed CMake files only and the Windows bots don't use CMake (yet).

Note You need to log in before you can comment on or make changes to this bug.