Bug 114549

Summary:

Add private interface to WKView to asynchronously update the drawing area size

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

WebKit2

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Gavin Barraclough 2013-04-12 17:39:01 PDT

This will allow a client using the WKView to resize the contents without blocking waiting for the web process to repaint.

Comment 1 Gavin Barraclough 2013-04-12 17:44:35 PDT

Created attachment 197915 [details]
Patch

Comment 2 Simon Fraser (smfr) 2013-04-12 18:07:36 PDT

Comment on attachment 197915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197915&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3445
> +// The updated is performed asynchronously; we don't wait for the geometry update before returning.

The update

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3464
> +        // If a geometry update is still pending then the action of recieving the

receiving

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3468
> +        drawingArea->waitForPossibleGeometryUpdate();
> +        drawingArea->waitForPossibleGeometryUpdate();

Do we really want to wait for a whole second?

Comment 3 Gavin Barraclough 2013-04-12 18:36:46 PDT

Fixed in:
Committed revision 148331.