Bug 114532

Summary:

Rename StyleBuilder to DeprecatedStyleBuilder

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

CSS

Assignee:

Dirk Schulze <krit>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, benjamin, commit-queue, esprehn+autocc, gyuyoung.kim, macpherson, menard, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

114508

Attachments:

Description	Flags
Patch	benjamin: review+
Patch for landing.	none

Dirk Schulze

Reported 2013-04-12 13:29:30 PDT

Rename StyleBuilder to DeprecatedStyleBuilder to clarify that new properties should not go into the template handling system. Note that the discussion is still ongoing on webkit-dev. The bug might be invalid at the end of the discussion.

Attachments
Patch (335.98 KB, patch) 2013-04-12 14:15 PDT, Dirk Schulze	benjamin: review+	Details Formatted Diff Diff
Patch for landing. (335.14 KB, patch) 2013-04-13 10:27 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2013-04-12 14:15:46 PDT

Created attachment 197884 [details] Patch

Benjamin Poulain

Comment 2 2013-04-12 14:18:26 PDT

Comment on attachment 197884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197884&action=review > Source/WebCore/ChangeLog:8 > + The StyleBuilder code is hard to read and maintain. People sould sould -> should

Benjamin Poulain

Comment 3 2013-04-12 14:19:22 PDT

Comment on attachment 197884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197884&action=review > Source/WebCore/css/DeprecatedStyleBuilder.cpp:2 > + * Copyright (C) 2011 Google Inc. All rights reserved. I think someone messed up with the copyright at some point. Most of that code was moved, not authored by google.

WebKit Commit Bot

Comment 4 2013-04-12 14:20:57 PDT

Attachment 197884 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/CSSAllInOne.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.h', u'Source/WebCore/css/StyleBuilder.cpp', u'Source/WebCore/css/StyleBuilder.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1 Source/WebCore/css/DeprecatedStyleBuilder.cpp:277: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:278: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:279: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:281: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:347: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:348: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:349: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:350: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:351: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:352: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:353: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:494: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:495: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:496: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:497: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:498: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:499: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:500: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:501: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:502: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:503: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:549: Omit int when using unsigned [runtime/unsigned] [1] Source/WebCore/css/DeprecatedStyleBuilder.cpp:577: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:579: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:580: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:581: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:582: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:866: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1010: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1011: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1012: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1132: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1134: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1173: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1175: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1633: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1634: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1635: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1636: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1637: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1638: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1639: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1640: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/css/DeprecatedStyleBuilder.cpp:1930: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/css/DeprecatedStyleBuilder.cpp:2230: Omit int when using unsigned [runtime/unsigned] [1] Source/WebCore/css/DeprecatedStyleBuilder.cpp:2232: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 48 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dirk Schulze

Comment 5 2013-04-12 17:12:03 PDT

(In reply to comment #3) > (From update of attachment 197884 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=197884&action=review > > > Source/WebCore/css/DeprecatedStyleBuilder.cpp:2 > > + * Copyright (C) 2011 Google Inc. All rights reserved. > > I think someone messed up with the copyright at some point. > Most of that code was moved, not authored by google. That might be. I'll hold on on landing this patch. It seems like Antti and rniwa have some more ideas and I want to check that first. See bug 114508

Dirk Schulze

Comment 6 2013-04-13 10:27:37 PDT

Created attachment 197949 [details] Patch for landing. Land patch.

WebKit Commit Bot

Comment 7 2013-04-13 10:58:56 PDT

Comment on attachment 197949 [details] Patch for landing. Clearing flags on attachment: 197949 Committed r148363: <http://trac.webkit.org/changeset/148363>

WebKit Commit Bot

Comment 8 2013-04-13 10:58:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.