Bug 114520

Summary: [GTK] Lower the pango dependency
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

Martin Robinson
Reported 2013-04-12 10:58:36 PDT
For WebKitGTK+ 2.0 we accidentally raised the Pango dependency higher than the version required by GTK+ 3.6. Since GTK+ 3.6 is the version of GTK+ that we depend on, we don't need to depend on such a new version of Pango.
Attachments
Patch (1.20 KB, patch)
2013-04-12 11:00 PDT, Martin Robinson 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2013-04-12 11:00:17 PDT
Created attachment 197869 [details] Patch
Carlos Garcia Campos
Comment 2 2013-04-12 11:03:02 PDT
(In reply to comment #0) > For WebKitGTK+ 2.0 we accidentally raised the Pango dependency higher than the version required by GTK+ 3.6. Since GTK+ 3.6 is the version of GTK+ that we depend on, we don't need to depend on such a new version of Pango. I was not accidentally, we raised it because it was the current stable (now it's 1.34), and the first one depending on hafbuzz which we depdend on now too. See the thread in the mailing list. I'm not saying I'm opposed to lower the dependency if it's causing trouble to people, though.
Carlos Garcia Campos
Comment 3 2013-04-12 11:05:35 PDT
Comment on attachment 197869 [details] Patch You could explain why in the ChangeLog, btw
Martin Robinson
Comment 4 2013-04-12 11:11:53 PDT
(In reply to comment #2) > (In reply to comment #0) > > For WebKitGTK+ 2.0 we accidentally raised the Pango dependency higher than the version required by GTK+ 3.6. Since GTK+ 3.6 is the version of GTK+ that we depend on, we don't need to depend on such a new version of Pango. > > I was not accidentally, we raised it because it was the current stable (now it's 1.34), and the first one depending on hafbuzz which we depdend on now too. See the thread in the mailing list. I'm not saying I'm opposed to lower the dependency if it's causing trouble to people, though. There was a bit of accidentalality on my part, at least.
Martin Robinson
Comment 5 2013-04-12 11:43:41 PDT
Committed r148293: <http://trac.webkit.org/changeset/148293>
Note You need to log in before you can comment on or make changes to this bug.