Summary: | [Qt][Win] r148257 broke the build | ||
---|---|---|---|
Product: | WebKit | Reporter: | Zoltan Arvai <zarvai> |
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | hausmann, jturcotte, kadam, oliver, ossy |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 114478 |
Description
Zoltan Arvai
2013-04-12 07:08:35 PDT
Committed r148280: <http://trac.webkit.org/changeset/148280> (In reply to comment #1) > Committed r148280: <http://trac.webkit.org/changeset/148280> #if PLATFORM(MAC) || PLATFORM(BLACKBERRY) -#define WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR 1 +#define BINDING_INTEGRITY 1 #endif Maybe this should be "ENABLE_BINDING_INTEGRITY" instead? (In reply to comment #2) > (In reply to comment #1) > > Committed r148280: <http://trac.webkit.org/changeset/148280> > > #if PLATFORM(MAC) || PLATFORM(BLACKBERRY) > -#define WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR 1 > +#define BINDING_INTEGRITY 1 > #endif > > Maybe this should be "ENABLE_BINDING_INTEGRITY" instead? whoah, that's an entirely bogus change, thanks for spotting it. O_o Reopen, because it didn't fix anything, the build is still broken. (In reply to comment #4) > Reopen, because it didn't fix anything, the build is still broken. Does QT set PLATFORM(WIN) ? (In reply to comment #5) > (In reply to comment #4) > > Reopen, because it didn't fix anything, the build is still broken. > > Does QT set PLATFORM(WIN) ? No, but OS(WIN). Thanks for http://trac.webkit.org/changeset/148405 , it fixed the build. Yay! Sorry for the delay. Seems icky to bludgeon out windows, but i think i need to do a bit more work to make binding generation windows friendly. |