Bug 114512
| Summary: | [Qt][Win] r148257 broke the build | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Zoltan Arvai <zarvai> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | hausmann, jturcotte, kadam, oliver, ossy |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 114478 | ||
Zoltan Arvai
After r148257 Qt Win build is broken. Maybe related to toJS changes, too.
http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Release/builds/64072/steps/compile-webkit/logs/stdio
WebCore.lib(JSNotification.obj) : error LNK2019: unresolved external symbol __ZTVN7WebCore12NotificationE referenced in function "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::Notification *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNotification@1@@Z)
WebCore.lib(JSInternals.obj) : error LNK2019: unresolved external symbol __ZTVN7WebCore9InternalsE referenced in function "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::Internals *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVInternals@1@@Z)
WebCore.lib(JSDOMSelection.obj) : error LNK2019: unresolved external symbol __ZTVN7WebCore12DOMSelectionE referenced in function "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::DOMSelection *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVDOMSelection@1@@Z)
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Oliver Hunt
Committed r148280: <http://trac.webkit.org/changeset/148280>
Jocelyn Turcotte
(In reply to comment #1)
> Committed r148280: <http://trac.webkit.org/changeset/148280>
#if PLATFORM(MAC) || PLATFORM(BLACKBERRY)
-#define WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR 1
+#define BINDING_INTEGRITY 1
#endif
Maybe this should be "ENABLE_BINDING_INTEGRITY" instead?
Oliver Hunt
(In reply to comment #2)
> (In reply to comment #1)
> > Committed r148280: <http://trac.webkit.org/changeset/148280>
>
> #if PLATFORM(MAC) || PLATFORM(BLACKBERRY)
> -#define WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR 1
> +#define BINDING_INTEGRITY 1
> #endif
>
> Maybe this should be "ENABLE_BINDING_INTEGRITY" instead?
whoah, that's an entirely bogus change, thanks for spotting it. O_o
Csaba Osztrogonác
Reopen, because it didn't fix anything, the build is still broken.
Oliver Hunt
(In reply to comment #4)
> Reopen, because it didn't fix anything, the build is still broken.
Does QT set PLATFORM(WIN) ?
Csaba Osztrogonác
(In reply to comment #5)
> (In reply to comment #4)
> > Reopen, because it didn't fix anything, the build is still broken.
>
> Does QT set PLATFORM(WIN) ?
No, but OS(WIN). Thanks for http://trac.webkit.org/changeset/148405 ,
it fixed the build.
Oliver Hunt
Yay! Sorry for the delay.
Seems icky to bludgeon out windows, but i think i need to do a bit more work to make binding generation windows friendly.