| Summary: | webkitbot should provide full name, email address, and IRC nicknames on whois | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, commit-queue, dpranke, kling, koivisto | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2013-04-12 00:09:41 PDT
Created attachment 197726 [details]
Fixes the bug
Comment on attachment 197726 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=197726&action=review > Tools/Scripts/webkitpy/tool/bot/irc_command.py:285 > + return "%s: %s is %s. Why do you ask?" % (nick, search_string, self._full_record_and_nick(contributor)) Shouldn't this be a unicode string too to avoid borking non-latin1 names? (for Tor Arne for example). I think Account also need __unicode__. From a quick look, it seems it only has __str__. > Tools/Scripts/webkitpy/tool/bot/irc_command.py:288 > return "%s: I'm not sure who you mean? %s could be '%s'." % (nick, contributors_string, search_string) ditto. > Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py:45 > whois = Whois() > self.assertEqual("tom: Usage: whois SEARCH_STRING", > whois.execute("tom", [], None, None)) > - self.assertEqual("tom: Adam Barth is abarth (abarth@webkit.org). Why do you ask?", > + self.assertEqual('tom: Adam Barth is "Adam Barth" <abarth@webkit.org> (:abarth) (r). Why do you ask?', [...] need a test for uncommon characters in names. Committed r148372: <http://trac.webkit.org/changeset/148372> |