Summary: | TimeRanges::nearest() returns incorrect results. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, esprehn+autocc, philn, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 114484 | ||||||||||||
Attachments: |
|
Description
Jer Noble
2013-04-11 17:35:30 PDT
"TimeRanges [1,2] -> nearest(0)" will return "0". Created attachment 197704 [details]
Patch
Comment on attachment 197704 [details] Patch Attachment 197704 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/105048 Created attachment 197714 [details]
Patch
Fixed windows build errors by adding symbols needed by WebCoreTestSupport to exports list.
Created attachment 197716 [details]
Patch
Added missing symbols to GTK build system.
Created attachment 197723 [details]
Patch
Now with more semicolons!
Comment on attachment 197723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197723&action=review > Source/WebCore/testing/Internals.cpp:2149 > + unsigned count = std::min(startTimes->length(), endTimes->length()); std::min() is unnecessary because you ASSERT above if the lengths are different. Comment on attachment 197723 [details] Patch Attachment 197723 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/131087 Committed r148288: <http://trac.webkit.org/changeset/148288> |