Bug 114462

Summary: Cannot scroll to footer on a page with overflow:hidden on the body
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, sam, simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Description Beth Dakin 2013-04-11 13:45:30 PDT 
If a WKView has a header/footer, you cannot scroll to the footer if the page has overflow:hidden on the body.

<rdar://problem/13530042>
Comment 1 Beth Dakin 2013-04-11 13:51:30 PDT 
Created attachment 197668 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-04-11 13:56:26 PDT 
Comment on attachment 197668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197668&action=review

> Source/WebCore/page/FrameView.cpp:614
> +        || (m_frame->page() && m_frame->page()->mainFrame() == m_frame && (headerHeight() || footerHeight()));

Why don't we have Frame::isMainFrame()? :(
Comment 3 Beth Dakin 2013-04-11 14:00:17 PDT 
(In reply to comment #2)
> (From update of attachment 197668 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=197668&action=review
> 
> > Source/WebCore/page/FrameView.cpp:614
> > +        || (m_frame->page() && m_frame->page()->mainFrame() == m_frame && (headerHeight() || footerHeight()));
> 
> Why don't we have Frame::isMainFrame()? :(

We REALLY should add this. 

http://trac.webkit.org/changeset/148234