Summary: | Support "forced" subtitles | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, esprehn+autocc, gyuyoung.kim, jer.noble, rakuco, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Eric Carlson
2013-04-11 13:24:03 PDT
Created attachment 197665 [details]
Proposed patch
Note: the new test added with this patch will not pass the bots because including the new media file in the patch makes it to large to attach. I will submit the new movie with the rest of the changes.
Attachment 197665 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/media/track/track-forced-subtitles-in-band-expected.txt', u'LayoutTests/media/track/track-forced-subtitles-in-band.html', u'LayoutTests/media/trackmenu-test.js', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/mac/TestExpectations', u'LayoutTests/platform/qt/TestExpectations', u'LayoutTests/platform/win/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/track/InbandTextTrack.cpp', u'Source/WebCore/html/track/TextTrack.cpp', u'Source/WebCore/html/track/TextTrack.h', u'Source/WebCore/page/CaptionUserPreferences.cpp', u'Source/WebCore/page/CaptionUserPreferences.h', u'Source/WebCore/page/CaptionUserPreferencesMac.mm', u'Source/WebCore/platform/graphics/InbandTextTrackPrivate.h', u'Source/WebCore/platform/graphics/PlatformTextTrack.h', u'Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/testing/Internals.h', u'Source/WebCore/testing/Internals.idl']" exit_code: 1
Source/WebCore/platform/graphics/InbandTextTrackPrivate.h:53: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/platform/graphics/InbandTextTrackPrivate.h:62: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/platform/graphics/PlatformTextTrack.h:50: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/platform/graphics/PlatformTextTrack.h:59: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 4 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 197669 [details]
Updated patch.
Note: the new test added with this patch will not pass the bots because including the new media file in the patch makes it to large to attach. I will submit the new movie with the rest of the changes.
|