Bug 114459

Summary:

Clean up related storage areas when a connection is destroyed

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	bdakin: review+

Description Anders Carlsson 2013-04-11 13:06:44 PDT

Clean up related storage areas when a connection is destroyed

Comment 1 Anders Carlsson 2013-04-11 13:08:34 PDT

Created attachment 197658 [details]
Patch

Comment 2 Anders Carlsson 2013-04-11 13:13:33 PDT

Committed r148229: <http://trac.webkit.org/changeset/148229>

Comment 3 Darin Adler 2013-04-12 07:49:46 PDT

Comment on attachment 197658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197658&action=review

> Source/WebKit2/UIProcess/Storage/StorageManager.h:82
> -    HashMap<std::pair<RefPtr<CoreIPC::Connection>, uint64_t>, RefPtr<StorageArea> > m_storageAreas;
> +    HashMap<std::pair<RefPtr<CoreIPC::Connection>, uint64_t>, RefPtr<StorageArea> > m_storageAreasByConnection;

I think a typedef for the pair type would really help readability. And probably a typedef for the map type too.