Bug 114459 - Clean up related storage areas when a connection is destroyed
Summary: Clean up related storage areas when a connection is destroyed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-11 13:06 PDT by Anders Carlsson
Modified: 2013-04-12 07:49 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.73 KB, patch)
2013-04-11 13:08 PDT, Anders Carlsson
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-04-11 13:06:44 PDT
Clean up related storage areas when a connection is destroyed
Comment 1 Anders Carlsson 2013-04-11 13:08:34 PDT
Created attachment 197658 [details]
Patch
Comment 2 Anders Carlsson 2013-04-11 13:13:33 PDT
Committed r148229: <http://trac.webkit.org/changeset/148229>
Comment 3 Darin Adler 2013-04-12 07:49:46 PDT
Comment on attachment 197658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197658&action=review

> Source/WebKit2/UIProcess/Storage/StorageManager.h:82
> -    HashMap<std::pair<RefPtr<CoreIPC::Connection>, uint64_t>, RefPtr<StorageArea> > m_storageAreas;
> +    HashMap<std::pair<RefPtr<CoreIPC::Connection>, uint64_t>, RefPtr<StorageArea> > m_storageAreasByConnection;

I think a typedef for the pair type would really help readability. And probably a typedef for the map type too.