Bug 114451

Summary:

Implement more logic in StorageAreaMap

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, mark.lam, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Description Anders Carlsson 2013-04-11 10:05:22 PDT

Implement more logic in StorageAreaMap

Comment 1 Anders Carlsson 2013-04-11 10:23:12 PDT

Created attachment 197638 [details]
Patch

Comment 2 Alexey Proskuryakov 2013-04-11 10:35:37 PDT

Comment on attachment 197638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197638&action=review

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:101
> +        // FIXME: If this is sent to another process, the source storage area won't make sense.

I don't understand this comment. What another process? Is this for the case when a process is restarted after a crash?

Please elaborate, unless you plan to address this very soon.

> Source/WebKit2/WebProcess/Storage/StorageAreaMap.cpp:133
> +    // FIXME: This should use a special sendSync flag to indicate that we don't want to process incoming messages while waiting for a reply.
> +    // (This flag does not yet exist).

It's not very obvious why.

Comment 3 Anders Carlsson 2013-04-11 10:42:48 PDT

Committed r148215: <http://trac.webkit.org/changeset/148215>