Bug 114414

Summary: [CSS Shaders] Parse mix descriptor
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: achicu, allan.jensen, commit-queue, dino, esprehn+autocc, macpherson, menard, michelangelo, mvujovic, ojan.autocc
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 113695    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dirk Schulze
Reported 2013-04-10 23:16:38 PDT
Parse mix descriptor on @filter rule.
Attachments
Patch (34.70 KB, patch)
2013-04-10 23:23 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (34.94 KB, patch)
2013-04-11 08:16 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (34.94 KB, patch)
2013-04-11 08:22 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2013-04-10 23:23:24 PDT
Created attachment 197511 [details] Patch
Antti Koivisto
Comment 2 2013-04-11 07:57:53 PDT
Comment on attachment 197511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197511&action=review > Source/WebCore/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). > + > + Add support for the 'mix' descriptor to support blend modes and composite > + operators in CSS Shaders. A brief description of what it does would be nice. You should also include a link to the spec.
Antti Koivisto
Comment 3 2013-04-11 08:00:48 PDT
Comment on attachment 197511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197511&action=review > Source/WebCore/css/CSSParser.cpp:2357 > + if (m_inFilterRule) > + return parseFilterRuleMix(); > + return false; I would do early return on exception. if (!m_inFilterRule) return false; ...
Dirk Schulze
Comment 4 2013-04-11 08:16:18 PDT
Created attachment 197589 [details] Patch
WebKit Commit Bot
Comment 5 2013-04-11 08:18:38 PDT
Comment on attachment 197589 [details] Patch Rejecting attachment 197589 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--non-interactive', 197589, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-commit-queue.appspot.com/results/17638084
Dirk Schulze
Comment 6 2013-04-11 08:22:25 PDT
Created attachment 197590 [details] Patch
WebKit Commit Bot
Comment 7 2013-04-11 08:54:01 PDT
Comment on attachment 197590 [details] Patch Clearing flags on attachment: 197590 Committed r148205: <http://trac.webkit.org/changeset/148205>
WebKit Commit Bot
Comment 8 2013-04-11 08:54:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.