Bug 114389

Summary: Inspector highlights are offset when the WKView has a header
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, sam, simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Beth Dakin
Reported 2013-04-10 16:01:54 PDT
Inspector highlights don't match up when the WKView has a header or footer. <rdar://problem/13522434>
Attachments
Patch (2.18 KB, patch)
2013-04-10 16:07 PDT, Beth Dakin 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2013-04-10 16:07:35 PDT
Created attachment 197413 [details] Patch
Sam Weinig
Comment 2 2013-04-10 16:19:17 PDT
Comment on attachment 197413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197413&action=review > Source/WebCore/platform/ScrollView.cpp:721 > + IntPoint viewPoint = contentsPoint + IntPoint(0, headerHeight()) - scrollOffset(); This should be an IntSize.
Beth Dakin
Comment 3 2013-04-10 16:24:47 PDT
Thanks, Sam! http://trac.webkit.org/changeset/148149
Note You need to log in before you can comment on or make changes to this bug.