Bug 114389

Summary:

Inspector highlights are offset when the WKView has a header

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

Layout and Rendering

Assignee:

Beth Dakin <bdakin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, sam, simon.fraser, thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Beth Dakin 2013-04-10 16:01:54 PDT

Inspector highlights don't match up when the WKView has a header or footer.

<rdar://problem/13522434>

Comment 1 Beth Dakin 2013-04-10 16:07:35 PDT

Created attachment 197413 [details]
Patch

Comment 2 Sam Weinig 2013-04-10 16:19:17 PDT

Comment on attachment 197413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197413&action=review

> Source/WebCore/platform/ScrollView.cpp:721
> +    IntPoint viewPoint = contentsPoint + IntPoint(0, headerHeight()) - scrollOffset();

This should be an IntSize.

Comment 3 Beth Dakin 2013-04-10 16:24:47 PDT

Thanks, Sam! http://trac.webkit.org/changeset/148149